Limych / ha-snowtire

Home Assistant sensor to predict if it's time to change car tires from summer to winter and vice versa.
Other
27 stars 12 forks source link

add summer icon #26

Closed phedoreanu closed 3 years ago

phedoreanu commented 3 years ago

Breaking change

Proposed change

This PR adds support for changing the sensor's icon ❄️ and ☀️.

Type of change

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

If user exposed functionality or configuration variables are added/changed:

phedoreanu commented 3 years ago

@Limych hey dude, would you please approve the remaining workflows and merge this PR? 😀

Limych commented 3 years ago

Thanks for your contribution to the project. The proposal is interesting, but there are a couple of notes, which see below.

phedoreanu commented 3 years ago

The mdi:snowflake icon is kind of ugly. I was thinking of changing it to the snowman one. Or even make them configurable?

What do you think?

Limych commented 3 years ago

The snowflake icon looks like a similar icon in the car's display panel and on the tires themselves. You shouldn't change it. If the user wants, he can always change any icon of any sensor through the settings in HA.

phedoreanu commented 3 years ago

Any chance of a new release? 😀

github-actions[bot] commented 3 years ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.