Lin-Shuang-Shuang / pe

0 stars 0 forks source link

Invalid phone numbers are accepted #11

Open Lin-Shuang-Shuang opened 2 months ago

Lin-Shuang-Shuang commented 2 months ago

When command add n/LinSS p/11111111111111111111111111111111111111111111111111111 e/johnd@example a/John street, block 123, #01-01 T/A r/Manager is given, the app does not throw an error message to say that the phone number is invalid. There should be some sort of checking conducted to see if the phone number is valid.

image.png

nus-se-bot commented 2 months ago

Team's Response

A caution is given in the UG to warn users from adding unrealistically long or invalid phone numbers, thus not a bug

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Feature flaw is defined as: Some functionality missing from a feature that the feature becomes less useful to the intended target user for normal usage. The app did not conduct a validity check for the phone number which could have resulted in mistakes when the user is inputting phone number into the app. Perhaps it would be better to display an error message if the length of the phone number is greater than 15.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]