Lin-Shuang-Shuang / pe

0 stars 0 forks source link

Allows duplicate employees to be added #3

Open Lin-Shuang-Shuang opened 2 months ago

Lin-Shuang-Shuang commented 2 months ago

When I add employees using this command add n/LinSS p/98765432 e/johnd@example.com a/John street, block 123, #01-01 T/A r/Manager twice, the app allows this, when it should have sent an error message to warn against duplicate employees.

image.png

soc-pe-bot commented 2 months ago

Team's Response

Duplicate employees are allowed by the application. As can be seen in the image the new employee has a different UID (Unique ID)

In the UG it's mentioned like this:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is a feature flaw as the app allowing duplicate employee details to be added could make the app more difficult to use. The user could have mistakenly entered the same employee detail twice, but added tasks to only 1 of the entry. When filtering for the employee to track his/her progress, there could be confusion as to which employee entry is the correct one.