search

LinSoftWin / Photoshop-CC2022-Linux

Installer from Photoshop CC 2021 to 2022 on linux with a GUI
BSD 3-Clause "New" or "Revised" License
898 stars 51 forks source link

Exported WINEPREFIX for better readability #20

Closed insanolanbiri closed 2 years ago

insanolanbiri commented 2 years ago

Using WINEPREFIX=~/.WineApps/Adobe-Photoshop in every wine related operation is not a good idea.

In this pr, that problem was fixed with exporting WINEPREFIX variable in scripts.

albakhtari commented 2 years ago

Have you tested this?

insanolanbiri commented 2 years ago

Have you tested this?

I realized I forgot to switch to wineprefix in some commands. I will make this pr ready for review when I fix.

MiMillieuh commented 2 years ago

Hello, don't bother yourself unless you really want to ... the script you modified is the old one for cc2021

I know it isn't that readable because the old script was intended to install only in that dir unlike the new one

Thanks for your contribution

MiMillieuh commented 2 years ago

I didn't saw that you modified the new one too but if I use this method it's to keep it compatible with the GUI version

insanolanbiri commented 2 years ago

I tested installing photoshop with file scripts/photoshop2022install.sh and it worked with this changes.

MiMillieuh commented 2 years ago

I tested installing photoshop with file scripts/photoshop2022install.sh and it worked with this changes.

Yeah it works in cli but it was also designed to work with the GUI

MiMillieuh commented 2 years ago

I tested installing photoshop with file scripts/photoshop2022install.sh and it worked with this changes.

Yeah it works in cli but it was also designed to work with the GUI

CLI might work but GUI isn't working that easy

MiMillieuh commented 2 years ago

After a test, it's not working with GUI version... I'm sorry but I can't merge it at the moment.

But still I really appreciate your contribution. Thanks it means a lot.

albakhtari commented 2 years ago

install only in that dir unlike the new one

Did you get that idea from my fork @MiMillieuh?

MiMillieuh commented 2 years ago

install only in that dir unlike the new one

Did you get that idea from my fork @MiMillieuh?

It was for the GUI installer since I find a way to get dir path through GUI I wanted to implement it but nothing comes from your fork...

insanolanbiri commented 2 years ago

@MiMillieuh Is gui app open source?

MiMillieuh commented 2 years ago

@MiMillieuh Is gui app open source?

It is but code is a bit messy...

Just don't try to work on it I have a lot of changes incoming on my local workplace