Reworked the script to work better

LinSoftWin / Photoshop-CC2022-Linux

Installer from Photoshop CC 2021 to 2022 on linux with a GUI

BSD 3-Clause "New" or "Revised" License

903 stars 50 forks source link

Closed Xenolphthalein closed 2 years ago

Xenolphthalein commented 2 years ago

Hey! I took your script and made some changes:

It now checks if the file already exists and does not redownload it if it already exists.
Files are checked against their md5sums now
Installer now does some checks if it did things correctly and exits if it detects an error
Added more verbose output and color coding
Removed two unnecessary dependencies: wget and zenity
Use variables for simpler replacement of urls or file paths
Fix the redist path with the latest allredist.tar.xz
Move camera raw installation to the end of the script
Move deletion of stuff to the end of the script

MiMillieuh commented 2 years ago

Hello,

Thanks for your contribution,

I just tested it and sadly it crashes : installer.sh: 50: Syntax error: "(" unexpected

If you can fix it well great job ^^

Anyway thanks for contribution to this project

Xenolphthalein commented 2 years ago

Sadly, I can't reproduce this issue. I am using arch linux and tried it with bash, zsh and sh. The error tells it should be the following two lines:

if ! md5sum --status -c <(echo -e $ALLREDIST_MD5 $ALLREDIST_FILE); then
if ! md5sum --status -c <(echo -e $PHOTOSHOP_MD5 $PHOTOSHOP_FILE); then

Could you please add a space between the < and the ( and try again? If that's the fix then i will update my code.