A missing comma found by Clang's latest -Wstring-concatenation

Linaro / OpenCSD

CoreSight trace stream decoder developed openly

https://github.com/Linaro/opencsd/wiki

Other

141 stars 53 forks source link

A missing comma found by Clang's latest -Wstring-concatenation #31

Closed yabinc closed 3 years ago

yabinc commented 3 years ago

In https://github.com/Linaro/OpenCSD/blob/master/decoder/source/etmv3/trc_pkt_elem_etmv3.cpp#L662, "Reserved","PE Reset","Reserved","HardFault"

A comma is missing after "HardFault"?

yabinc commented 3 years ago

external/OpenCSD/decoder/source/etmv3/trc_pkt_elem_etmv3.cpp:663:9: error: suspicious concatenation of string literals in an array initialization; did you mean to separate the elements with a comma? [-Werror,-Wstring-concatenation] \"Reserved\",\"BusFault\",\"Reserved\",\"Reserved\"

mikel-armbb commented 3 years ago

Hi,

Thanks for this report. Will fix in next release.

Mike

mikel-armbb commented 3 years ago

fixed in v0.14.4