search

Linaro / OpenCSD

CoreSight trace stream decoder developed openly
https://github.com/Linaro/opencsd/wiki
Other
141 stars 53 forks source link

Support generation of last branch events with perf inject #8

Closed sebpop closed 7 years ago

sebpop commented 7 years ago

Mathieu, I just squashed the last patch in, and I removed the empty line. Let me know if I need to change something else. Thanks for your review!

sebpop commented 7 years ago

Mathieu, I updated the patch and added more comments explaining how the circular buffers are managed. I have removed the FIXME note as I implemented a way to drain the last branches from the circular buffer. In reading the code again, I had to add two extra FIXME notes: one about trace sampling not working, and a question or assumption that I am making about the ETM traces, maybe you can help clearing that one out: does an ETM trace that we get from cs_etm__get_trace() only contain branches from a single cpu?

Thanks, Sebastian

mathieupoirier commented 7 years ago

On 14 December 2016 at 15:21, sebpop notifications@github.com wrote:

Mathieu, I updated the patch and added more comments explaining how the circular buffers are managed. I have removed the FIXME note as I implemented a way to drain the last branches from the circular buffer. In reading the code again, I had to add two extra FIXME notes: one about trace sampling not working, and a question or assumption that I am making about the ETM traces, maybe you can help clearing that one out: does an ETM trace that we get from cs_etm__get_trace() only contain branches from a single cpu?

Good morning,

When adding FIXME notes, please add a comment that explains what is currently blocking the implementation.

As for "cs_etm__get_trace(), I haven't authored the original code and it's been a long time since I looked at it but it's taking input from the perf.data file itself so I would say that it can contain traces from any CPU.

Mathieu

Thanks, Sebastian

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Linaro/OpenCSD/pull/8#issuecomment-267175524, or mute the thread https://github.com/notifications/unsubscribe-auth/AAi322yd-r2SypPlOWtCaJCOY57iXudjks5rIGv5gaJpZM4LNDz7 .

mikel-armbb commented 7 years ago

This pull request has been applied to the latest perf-opencsd code - and further update. Now in https://github.com/Linaro/perf-opencsd repository, autoFDO branch Closing pull request as it does not apply here any more