Closed BaptisteGerondeau closed 6 years ago
This tree is now broken and will break master if I merge. Please rebase and get rid of any merge commit, to leave only the actual changes in the code from the current master.
What's the purpose of the unique_id ? I erased it in the merge, since it doesn't do anything and is just renaming $BUILD_NUMBER.
What's the purpose of the unique_id ? I erased it in the merge, since it doesn't do anything and is just renaming $BUILD_NUMBER.
It's used in the harness. Don't erase it, please.
unique_id and --benchmark-root name change taken into account and pushed.
I'll test this in the lab today.
Too much "references" clutter this page, at this time, I squashed everything into one commit : https://github.com/Linaro/hpc_lab_setup/commit/cb03c8f36bed3fd2f728db0ba521c692051eddc5
Quick comment: avoid "PR #59" comments in the commit message. This can change and is largely irrelevant what the PR number is.
It also confuses me as I keep thinking GitHub is doing silly things to your commits... :)
So, I installed this on the lab and it runs well with two issues:
Maybe we can check the tools before updating the packages, so that it works with even more different systems?
Working well on the lab, awesome, thanks!
Only concerns the benchmark_job, whose structure hasn't been modified aside from the ansible being in the repo now.