Linaro / hpc_lab_setup

Jenkins Jobs for HPC Lab
Apache License 2.0
5 stars 4 forks source link

Merged hpc_deploy_benchmarks, and refactored it #59

Closed BaptisteGerondeau closed 6 years ago

BaptisteGerondeau commented 6 years ago

Only concerns the benchmark_job, whose structure hasn't been modified aside from the ansible being in the repo now.

rengolin commented 6 years ago

This tree is now broken and will break master if I merge. Please rebase and get rid of any merge commit, to leave only the actual changes in the code from the current master.

BaptisteGerondeau commented 6 years ago

What's the purpose of the unique_id ? I erased it in the merge, since it doesn't do anything and is just renaming $BUILD_NUMBER.

rengolin commented 6 years ago

What's the purpose of the unique_id ? I erased it in the merge, since it doesn't do anything and is just renaming $BUILD_NUMBER.

It's used in the harness. Don't erase it, please.

rengolin commented 6 years ago

https://github.com/Linaro/ansible-deploy-benchmarks/commit/4b576faa76ffac3a4895fc35909195baf9e2674c

and

https://github.com/Linaro/ansible-deploy-benchmarks/commit/ecac3dbef3ffc0d91c5a67c3cfc8a93d2728492e

BaptisteGerondeau commented 6 years ago

unique_id and --benchmark-root name change taken into account and pushed.

rengolin commented 6 years ago

I'll test this in the lab today.

BaptisteGerondeau commented 6 years ago

Too much "references" clutter this page, at this time, I squashed everything into one commit : https://github.com/Linaro/hpc_lab_setup/commit/cb03c8f36bed3fd2f728db0ba521c692051eddc5

rengolin commented 6 years ago

Quick comment: avoid "PR #59" comments in the commit message. This can change and is largely irrelevant what the PR number is.

It also confuses me as I keep thinking GitHub is doing silly things to your commits... :)

rengolin commented 6 years ago

So, I installed this on the lab and it runs well with two issues:

  1. MrP client's url/token arguments are swapped
  2. Installation of perf is not successful on Ubuntu, but it works on Debian

Maybe we can check the tools before updating the packages, so that it works with even more different systems?

rengolin commented 6 years ago

Working well on the lab, awesome, thanks!