search

Linaro / hpc_lab_setup

Jenkins Jobs for HPC Lab
Apache License 2.0
5 stars 4 forks source link

Add openSUSE Leap 15.1 support #78

Closed ggardet closed 5 years ago

BaptisteGerondeau commented 5 years ago

Great ! Thanks a lot ! Does this depend on your MrP patch ?

ggardet commented 5 years ago

Great ! Thanks a lot ! Does this depend on your MrP patch ?

Yes, I would like to validate the MrP patch before (the ssh key placeholder part). That's why I added the [WIP]

ggardet commented 5 years ago

@BaptisteGerondeau this PR should be ready to merge now.

BaptisteGerondeau commented 5 years ago

In fact, could you add the autoyast file to vars/list_preseeds.yml please ? That's the only thing :)

Aside from that, looks good to me !

BaptisteGerondeau commented 5 years ago

@ggardet

ggardet commented 5 years ago

In fact, could you add the autoyast file to vars/list_preseeds.yml please ?

It was lost while rebasing. Sorry, I will push the updated version now.

BaptisteGerondeau commented 5 years ago

LGTM ! Thank you for everything !!!

ggardet commented 5 years ago

@BaptisteGerondeau any ETA for deployment?

BaptisteGerondeau commented 5 years ago

@ggardet Doing validation tests now, will keep you posted but this should be up tomorrow

BaptisteGerondeau commented 5 years ago

@ggardet All tests were good and its in production now ! Thanks again !

ggardet commented 5 years ago

@BaptisteGerondeau thanks for testing and for the deployment! We just need to merge this PR and MrP's PR.

rengolin commented 5 years ago

MrP's request can be merged later, as we have it on our lab. So this task is over, thanks!