search

Linaro / lite-lava-docker-compose

LITE Team LAVA docker dispatcher
MIT License
5 stars 10 forks source link

Usb passthrough #110

Closed galak closed 4 years ago

galak commented 4 years ago

Updates to usb-passthrough script to match the set of devices expected by lava docker action.

The lava code uses pyudev to determine what device nodes should be passed to a container. We need to pass the same set of device nodes in usb-passthrough so we match the logic there.

pfalcon commented 4 years ago

Looked thru commits, make sense. As I'm not very familiar with this area, the only unclear thing is with commit "usb-passthrough: rework how we get props for mknod". It says:

On Add we stat the device node file and extract the major/minor and device type (char, binary) and refactor that into a function.

On Remove we still get them from the environment vars, as the device node file will already have been removed by the time we get here.

My understanding is that previously, we used properties (major/minor) from envvars as passed by udev for both Add and Remove, and from the commit, it's not clear, why we switch to stat() a device node for the Add case instead.

Will test with frdm_k64f ASAP.

@erwango: Perhaps, you may be interested to test with your setup too, to make sure that everything keeps working.

erwango commented 4 years ago

@erwango: Perhaps, you may be interested to test with your setup too, to make sure that everything keeps working.

Will try to get it done by tomorrow.

erwango commented 4 years ago

Sorry guys, I won't have time to test this before 10 days...

galak commented 4 years ago

Sorry guys, I won't have time to test this before 10 days...

No worries, I thought this was all I needed for lava-dispatcher running in docker + docker lava test shell to work but its not.

pfalcon commented 4 years ago

@erwango: Did you have a chance to give this a try? If not, it's ok, it's mostly to keep everyone in loop of testing/lava ;-). But I'd like to merge this, so we had all the pending changes in, for the sprint next week.

pfalcon commented 4 years ago

Merging.

erwango commented 4 years ago

@erwango: Did you have a chance to give this a try? If not, it's ok, it's mostly to keep everyone in loop of testing/lava ;-). But I'd like to merge this, so we had all the pending changes in, for the sprint next week.

Sorry, had a dense agenda for this return from holidays..

pfalcon commented 4 years ago

Sorry, had a dense agenda for this return from holidays..

No problem, we have that mini-sprint next week to pay attention to that stuff ;-).