search

Linaro / lite-lava-docker-compose

LITE Team LAVA docker dispatcher
MIT License
5 stars 10 forks source link

docker-compose.yaml: ser2net: Reduce port range exported to the host. #128

Closed pfalcon closed 3 years ago

pfalcon commented 3 years ago

5000-5099 is 100 ports, and that range can be occupied by other services on localhost. For example, 5037 is the default port for Android adbd. The larger the range, the higher chance of conflict. 10 ports/devices should be more than enough for a typical local LAVA deployment. (And if more needed, that can be extended as part of private config, similar to board serials, etc.)

Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org

pfalcon commented 3 years ago

@galak, So, based on our Slack discussion, I changed to ports 5000-5036 (5037 is abd). I don't think that changing the starting port would help much, and we kinda would be asking people to regenerate their existing configs (or not, and then potentially hit confusion points, where we tell people "just use telnet localhost 7001" and they reply "nope, doesn't work", and we need to scratch our heads why).

Anyway, IMHO too much bikeshedding for a pretty minor issue already ;-), can revisit any time. Merging.