search

Linaro / lite-lava-docker-compose

LITE Team LAVA docker dispatcher
MIT License
5 stars 10 forks source link

Makefile: Add "build" target to prepare for and build docker-compose … #26

Closed pfalcon closed 5 years ago

pfalcon commented 5 years ago

…images.

The motivation to introduce such a target was to e.g. download and cache big files locally before building images. That feature isn't realized yet, but docs already refer to "make build", so let's have it here.

pfalcon commented 5 years ago

As the commit message mentions, https://collaborate.linaro.org/pages/viewpage.action?pageId=118293253#GettingStartedwithLAVA,Docker,andaFRDM-K64F:-(Semi)AutomatedContainerizedSetup section already refers to "make build". In my branch, I have changes to download SDK piece only once on host, but not e.g. JLink binary, which also can take a minute or 2 on slow connection. So, I'd like to elaborate it before trying to submit, and in the meantime, this trivial implementation for future-proofness.

pfalcon commented 5 years ago

Ping @galak .

pfalcon commented 5 years ago

Ok, as this is fairly trivial patch, and adds a feature which is described as required in the docs, and I happen to have merge rights, let me not overflow this onto next week, and merge this now.