search

Linaro / lite-lava-docker-compose

LITE Team LAVA docker dispatcher
MIT License
5 stars 10 forks source link

Upgrade to LAVA 2019.12 #45

Closed pfalcon closed 4 years ago

pfalcon commented 4 years ago

Upgrade to LAVA 2019.12 (upstream commits).

pfalcon commented 4 years ago

cc: @edmooring

pfalcon commented 4 years ago

I did sanity check with both old and new (waiting for 2019.12) jobs. Everything works as expected. Note that https://lite.validation.linaro.org/ is already upgraded, so it doesn't make much sense to linger behind it.

pfalcon commented 4 years ago

Just for reference, there was another upstream commit added recently which I skipped cherry-picking: https://github.com/Linaro/lite-lava-docker-compose/commit/dccc4b16473a99c84da6f39e4477b2420d05eff1 . I personally do restarts using "make stop/make" quite regularly, so adding operation with network latency doesn't look like a good idea. Alternatively, we can pull it, but revert. Alternatively, interested parties can revert it in their working branches.

pfalcon commented 4 years ago

Oh, and actually, another upstream commits breaks things for us: "Do not name containers" (https://github.com/Linaro/lite-lava-docker-compose/commit/962cb9b5f8debcbe9f6d9d0ae30deeb117fdccb0). It breaks a bunch of stuff in the Makefile for us, e.g. docker exec -it lava-server ... doesn't work, because of explicit lava-server name, there's now a name auto-generated by docker-compose.

So, I'm removing this commit from this PR. (And we'll need to remember that our way to upgrade to upstream is cherry-picking commits from it, not rebasing on (this was the case so far)).

pfalcon commented 4 years ago

Posted an issue upstream: https://git.lavasoftware.org/lava/pkg/docker-compose/issues/5 (not as much as hoping that they would revert it, as to provide feedback "there are downstream users, and even simple changes may have cascading effect").

pfalcon commented 4 years ago

Ok, merging.