search

Linaro / lite-lava-docker-compose

LITE Team LAVA docker dispatcher
MIT License
5 stars 10 forks source link

Makefile: Use "docker-compose exec" instead of "docker exec". #94

Closed pfalcon closed 4 years ago

pfalcon commented 4 years ago

docker-compose and docker somehow use different namespaces for the names, where docker's name is exact and concrete, while docker-compose name is a logical name, from which a conrete is normally formed by namespacing the logical name using a docker-compose project directory (so, there potentially can be different deployments of the same project, residing in different filesystem directories). It works that way, unless exact docker name is explicitly overriden.

When we forked lava-docker-compose, it exactly used overriden names. But later they were dropped. We however didn't (cherry-)pick that name, for the fear that it may break our setup infra we built on top of the original project.

So, if anything, this change brings us closer to the setup used in upstream master, with the intention that we could pick that upstream change later (and so reduce delta to upstream).

Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org

pfalcon commented 4 years ago

@galak: FYI. I kinda wanted to post to the mailing list re: "we're behind lava-docker upstream, and what to do about it", but here's it in the commit message, on a related case. Summing up, I don't think that we're missing out anything important to our usecase (or I wouldn't omit it). Roughly speaking, I think we could address that ~ at the sprint next year ;-). But then I don't know if it might affect work you're doing (controlling dispatcher better), so wanted to bring in it up.

pfalcon commented 4 years ago

Beyond implications on the maintenance of our branch, this is pretty minor change, so merging.