search

Linaro / meta-qcom

OpenEmbedded/Yocto Project BSP layer for Qualcomm based platforms
MIT License
62 stars 70 forks source link

linux-qcom-bootimg: Fix SyntaxWarning messages #495

Closed daniel-thompson closed 1 year ago

daniel-thompson commented 1 year ago

Currently linux-qcom-bootimg.inc issues warnings like the following with some versions of Python 3:

WARNING: linux-linaro-qcomlt-6.0-r0 do_qcom_img_deploy: .../meta-qcom/recipes-kernel/linux/linux-qcom-bootimg.inc:51: SyntaxWarning: "is" with a literal. Did you mean "=="?

Using is to test for equality is wrong. is only works "by accident" and relies on some rather dubious assumptions about how CPython manages the string literal pool

There are three occurrences, the first two are fixed the obvious way and the final one is simply removed because the code was unreachable anyway (the empty string already evaluates to False when used in a logic expression).

Signed-off-by: Daniel Thompson daniel.thompson@linaro.org

ndechesne commented 1 year ago

thanks! I noticed the warnings when build testing last week, and wanted to look at them! I don't understand $subject you've used though.

daniel-thompson commented 1 year ago

thanks! I noticed the warnings when build testing last week, and wanted to look at them! I don't understand $subject you've used though.

Oops... I used a previous commit message to keep the right commit style and it looks like I forgot to update the template ;-)

Fixed.