Linaro / meta-qcom

OpenEmbedded/Yocto Project BSP layer for Qualcomm based platforms
MIT License
62 stars 70 forks source link

qcom-sdxmdm: add the machine conf governing SDX and MDM platforms #496

Closed lumag closed 1 year ago

lumag commented 1 year ago

Follow the qcom-armv8a and qcom-armv7a lead and provide a unified machine configuration for Qualcomm modem platforms (including, but not limited to sdx55, sdx65 and mdm9615).

Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

lumag commented 1 year ago

@Mani-Sadhasivam , @superna9999 , could you please also give it a glance?

ndechesne commented 1 year ago

if we do such a generic machine, I think we at least need to include the underlying arch, eg. armv7a in the name. We also need to pick sdx or mdm, i believe they are just 2 marketing names for the same thing, no?

lumag commented 1 year ago

These names were used for different generations of modems. I'm a little bit hesistant to include armv7a into the machine name. But to be fully future proof, maybe it should be done. What about qcom-armv7a-modem?

Mani-Sadhasivam commented 1 year ago

LGTM!

ndechesne commented 1 year ago

Where are planning to set PREFERRED_PROVIDER_virtual/kernel ?

lumag commented 1 year ago

Where are planning to set PREFERRED_PROVIDER_virtual/kernel ?

The preference for the virtual/kernel is set in the qcom-common.inc

ndechesne commented 1 year ago

Where are planning to set PREFERRED_PROVIDER_virtual/kernel ?

The preference for the virtual/kernel is set in the qcom-common.inc

ouch.. sorry, i missed that you included this file!