Add firmware package support for RB3Gen2

[kraparthy]

Add firmware package support for RB3Gen2

Currently, firmware zip is not posted on SRC_URI mentioned in the patch this request to get the review done on changes

[lumag]

Also could you please update MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS to include the new packagegroup.

[kraparthy]

• Please use your real name for the S-o-b tags. I am using my real name in signed of by. could you pls share the details that i can take care

[lumag]

• Please use your real name for the S-o-b tags.

I am using my real name in signed of by. could you pls share the details that i can take care

This is from the last patch:

Signed-off-by: kraparthy <quic_kraparth@quicinc.com>

And also: Author: kraparthy <quic_kraparth@quicinc.com>

[lumag]

@kraparthy last commit still lists kraparthy <quic_kraparth@quicinc.com> as commit author.

[lumag]

I'm reading through the license. Could you please clarify the implications by the change in the redistribution restrictions:

Current text:

(ii) the Redistributable Binary Code may only operate in conjunction with platforms incorporating Qualcomm Technologies, Inc. chipsets;

New text:

(ii) the Redistributable Binary Code may only operate in conjunction with platforms that contain a semiconductor product sold under QTI’s (or QTI’s affiliates’) label or manufactured under license from QTI (or QTI’s affiliates) (“Platform”);

[lumag]

Also this paragraph looks troublesome:

In addition, You shall not attempt, knowingly permit or encourage others to attempt to: (i) make any copies of the Licensed Materials except as otherwise permitted under Section 1.1 (License Grant) of this Agreement in the case of Software and under Section 1.3 (Documentation) of this Agreement in the case of Documentation; (ii) rent, lease, loan, reproduce (except as to the Redistributable Binary Code, as expressly set forth in Section 1.1 (License Grant) of this Agreement, and the Documentation as expressly set forth in Section 1.3 (Documentation) of this Agreement ), modify, distribute (except as to the Redistributable Binary Code, as expressly set forth in Section 1.1 (License Grant) of this Agreement), publicly perform, publicly display or create derivative works of or based on the Licensed Materials, or disclose, provide or otherwise distribute or transfer, in any manner, to any third party the Licensed Materials or any portion thereof (except as to the Redistributable Binary Code, as expressly set forth in Section 1.1 (License Grant) of this Agreement); or (iii) use the Licensed Materials for any purpose other than as expressly permitted in the case of the Software, Section 1.1 (License Grant) of this Agreement, and in the case of Documentation, Section 1.3 (Documentation) of this Agreement.

[lumag]

Generally this license text seems troublesome. I'd like to counsel our lawyers and/or linux-firmware@ and Debian legal before accepting this pull request. I can not be 100% sure about the risks that we will partake if we create and put online the rootfs image created using these binaries. Nor can I be sure that linux-firmware maintainers and further upstream Linux distribution maintainers will accept binaries distributed under this license.

[kraparthy]

Generally this license text seems troublesome. I'd like to counsel our lawyers and/or linux-firmware@ and Debian legal before accepting this pull request. I can not be 100% sure about the risks that we will partake if we create and put online the rootfs image created using these binaries. Nor can I be sure that linux-firmware maintainers and further upstream Linux distribution maintainers will accept binaries distributed under this license.

I have shared your feedback on License with internal team. we will discuss internally and update

[lumag]

Thank you!

[kraparthy]

• I still don't see the Adreno shader. Please add it.
• Please provide WiFi BDF file. It can be provided later as a separate pull requst or as a part of this pull request.

Internal team is working on pushing ZAP shader to linux firmware git. I'll raise new request once it is pushed Same with WiFi BDF file

[lumag]

• I still don't see the Adreno shader. Please add it.
• Please provide WiFi BDF file. It can be provided later as a separate pull requst or as a part of this pull request.

Internal team is working on pushing ZAP shader to linux firmware git. I'll raise new request once it is pushed Same with WiFi BDF file

I hope that your team is also working on pushing adsp and cdsp firmware to that repo. However once those files are a part of the linux-firmware, this recipe can be mostly dropped (or simply install an next-to-empty package like other firmware recipes do). The purpose of this recipe is to provide those files before they are able to hit linux-firmware release. So, please provide it as a part of this PR. Dixi.

[lumag]

it = Adreno ZAP shader.

[lumag]

@kraparthy Any updates regarding the ZAP shader?

[kraparthy]

@kraparthy Any updates regarding the ZAP shader?

@lumag , Team is waiting for Legal approval to push the ZAP shader to no login firmware zip but it is going to happen soon If you are okay, i can push another patch ZAP shader once Legal approval is in place. Otherwise, i can push the new patch once the Legal approval is in place and team pushes the new firmware zip

[lumag]

@kraparthy I still consider firmware package to be incomplete w/o ZAP shader. Also I noticed that recent patches enable modem and wnss remoteprocs and as such they depend on modem and wnss firmware being provided, but I don't see these packages being enabled in this recipe.

[lumag]

@kraparthy as this keeps

[adhudase]

Hi @lumag, zap shader, modem and other firmware bins are still not available in public domain (no-login release) pending legal approval. We'll keep you posted on any updates regarding this matter.

Since @kraparthy has moved to another project and won't be able to continue with this PR, I will take over this. Shall we continue with same PR or create a new one?

Thanks

[lumag]

@adhudase Please don't use 'public domain' for licensed software. It is a separate legal status with its own set of rights. We have never asked to release firmware as 'public domain'.

Regarding your question. Since you can not write to @kraparthy's tree, you will have to create new PR once requested firmware blobs become available.

[adhudase]

@adhudase Please don't use 'public domain' for licensed software. It is a separate legal status with its own set of rights. We have never asked to release firmware as 'public domain'.

Sorry, my bad.

Regarding your question. Since you can not write to @kraparthy's tree, you will have to create new PR once requested firmware blobs become available.

Sure, will do.

[konradybcio]

I see that this provides /lib/firmware/qcom/qc*m*6490, whereas the upstream dt expects /lib/firmware/qcom/qc*s*6490.. which one do we go with in the end?

[lumag]

I hope the upstream one. Maybe somebody confused RB3g2 (qcs) and qcm6490-IDP

[lumag]

Replaced by #619