search

Linaro / meta-qcom

OpenEmbedded/Yocto Project BSP layer for Qualcomm based platforms
MIT License
61 stars 70 forks source link

uki: drop INITRAMFS_IMAGE support #559

Closed lumag closed 7 months ago

lumag commented 8 months ago

Enabling INITRAMFS_IMAGE and UKI results in the dependency loop. Initramfs depends on the kernel to be packaged, while the kernel's do_install gets dependency on the initramfs do_image_complete task.

Drop the whole INITRAMFS_IMAGE support from the uki.bbclass. One should use systemd-boot's initrd support natively.

lumag commented 8 months ago

cc @sbanerjee-quic

sbanerjee-quic commented 8 months ago

cc @sbanerjee-quic

@lumag we will review and feedback. We have a long weekend.

cc @quic-vkraleti

quic-vkraleti commented 8 months ago

As I understand, systemd-boot's initrd is valid only for Type1. For Type2, initrd is expected to be part of UKI only. Anyways I'll cross check with UEFI engineer and confirm if it is acceptable to have nitrd outside of UKI even for Type#2.

lumag commented 8 months ago

@quic-vkraleti I'm not sure, what is Type1 / Type2 here. A reference would be a appreciated. Anyway, currently built-in initrd support is broken, try building such config on your own.

quic-vkraleti commented 8 months ago

@quic-vkraleti I'm not sure, what is Type1 / Type2 here. A reference would be a appreciated. Anyway, currently built-in initrd support is broken, try building such config on your own.

https://uapi-group.org/specifications/specs/boot_loader_specification/#the-boot-loader-specification describes details about Type#1 & Type#2 specifications. Goal is to support Type#2 and this mandates initrd to be part of UKI.

Regd broken built-in initrd support, can you share more details on how to reproduce? As I see even kernel.bblcass is fetching initrd from INITRAMFS_DEPLOY_DIR_IMAGE, which is a soft assignment to DEPLOY_DIR_IMAGE. uki.bbclass is also using the same to get initrd.

lumag commented 8 months ago

For me it was simple, I enabled INITRAMFS_IMAGE = "initramfs-test-image" and got a errors regarding the task dependency loop.

quic-vkraleti commented 7 months ago

For me it was simple, I enabled INITRAMFS_IMAGE = "initramfs-test-image" and got a errors regarding the task dependency loop.

From build POV, ramdisk image is also another image which by default it pulls in a dependency on do_packagedata task of kernel. Here uki.bbclass is trying to create kernel-uki package, that need ramdisk image to complete. This is the cause for circular dependency. To address this, need to stop creating kernel-uki package and place efi image in deploydir instead.

lumag commented 7 months ago

Closed in favour of #562 which provides a better, more complex solution