qdl: update to the latest upstream

Linaro / meta-qcom

OpenEmbedded/Yocto Project BSP layer for Qualcomm based platforms

MIT License

60 stars 69 forks source link

qdl: update to the latest upstream #599

Closed ricardosalveti closed 1 month ago

ricardosalveti commented 1 month ago

Update to the latest upstream repository, which is now at https://github.com/linux-msm/qdl.git.

Relevant changes from latest upstream:

USBDEVFS interface replaced with libusb
Add ramdump support
New utility 'ks' which uses sahara to load images from host to a device (relevant for Qualcomm Cloud AI 100).

Drop 0001-Makefile-Use-pkg-config-for-libxml2-detection.patch as these changes are now available upstream.

lumag commented 1 month ago

Also there is no need to list upstream changelog in the commit message. Please drop it. Instead provide a rationality, why the package needs to be upgraded.

ricardosalveti commented 1 month ago

Fails for me:

ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: QA Issue: File /usr/bin/ks in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl-ramdump in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: Fatal QA errors were found, failing task.
ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp-rpb-glibc/work/armv8a-linaro-linux/qdl/0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314/temp/log.do_package_qa.3081535

Didn't fail for me, but could be my settings / environment, will test on a basic / clean setup.

ricardosalveti commented 1 month ago

Also there is no need to list upstream changelog in the commit message. Please drop it. Instead provide a rationality, why the package needs to be upgraded.

Sure, this is a common practice on other layers, which is why I added, but will remove.

ricardosalveti commented 1 month ago

CI failures not related to this change.

ricardosalveti commented 1 month ago

Fails for me:

ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: QA Issue: File /usr/bin/ks in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?)
File /usr/bin/qdl-ramdump in package qdl doesn't have GNU_HASH (didn't pass LDFLAGS?) [ldflags]
ERROR: qdl-0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314-r0 do_package_qa: Fatal QA errors were found, failing task.
ERROR: Logfile of failure stored in: /home/lumag/Projects/RPB/build-rpb/tmp-rpb-glibc/work/armv8a-linaro-linux/qdl/0.0+b18bca7d285a3ade92b6ec94b5d41fa149658314/temp/log.do_package_qa.3081535

Didn't fail for me, but could be my settings / environment, will test on a basic / clean setup.

I think I see what caused this, patch I dropped (which needs to be removed) changed ldflags to append instead of a force set. Will send this upstream first and get back to this.

ricardosalveti commented 1 month ago

Updated and removed the local patch since it is not required anymore (after cflags/ldflags issue was merged upstream: https://github.com/linux-msm/qdl/pull/63).