search

Linaro / meta-qcom

OpenEmbedded/Yocto Project BSP layer for Qualcomm based platforms
MIT License
62 stars 70 forks source link

Add firmware package support for QCS6490 RB3Gen2 #619

Closed adhudase closed 3 weeks ago

adhudase commented 1 month ago

Add firmware package support for QCS6490 RB3Gen2 board.

This PR addresses the same purpose as the existing PR #551. However, due to limitations in writing to @kraparthy’s tree, we created this fresh PR. Please note that @kraparthy is no longer part of this project.

lumag commented 1 month ago

CI log shows that it wasn't even tested. Please don't submit untested patches.

lumag commented 1 month ago

Also please describe in the PR description, why you are opening a new one for the same purpose as the existing one, #551.

lumag commented 1 month ago

Also, what is the plan for the WiFi BDF files? Have you sent them to ath11k@ ML? Are you going to provide a patched board-2.bin as a part of this recipe?

adhudase commented 4 weeks ago

Thanks for review @lumag.

We have plans to share the WiFi BDF files, but I don’t have a specific date yet. Unfortunately, since board-2.bin is also not available in CLO, I cannot provide it in this recipe.

lumag commented 4 weeks ago

You can rebuild it, please see the history of dragonboard/RB firmware recipes.

lumag commented 3 weeks ago

@adhudase any updates?

adhudase commented 3 weeks ago

Sorry, I was OOTO; looking into this now. Had some issues using ath11k-generate-board-2_json.sh/ath10k-bdencoder. I'll update it today. Thanks

lumag commented 3 weeks ago

@adhudase as a side note please use Adreno SQE and GMU binaries from the main Linux-firmware repo, unless there is a really good reason to update those files.

Ideally Qualcomm should update those files first, if there is anything important.

lumag commented 3 weeks ago

If an update is pending, feel free to provide updated files (using alternatives/preferred provider mechanism), but at least that should be documented as a temporal solution with the clear date when upstream is updated.

lumag commented 3 weeks ago

Had some issues using ath11k-generate-board-2_json.sh/ath10k-bdencoder. I'll update it today.

I'm fine with getting bdwlan later on, if you can not resolve the issues. Ping me next week and we can try solving them.

adhudase commented 3 weeks ago

@lumag updated PR and addressed review comments. Please take a look. Thanks

lumag commented 3 weeks ago

@adhudase I noticed that several commits lack your SoB tag. Please add it

lumag commented 3 weeks ago

Thank you!

lumag commented 2 weeks ago

@adhudase I'm really unsatisfied and surprised here. I could not manually verify the PR while merging it. In fact I had no reason not to trust that it does what it promises. However, generated WiFi board file is empty. This means that you haven't tested the code that you are submitting. First iteration of this PR also wasn't tested at all (it failed to build images because of the file conflict). Please actually verify what you are doing before submitting code upstream.

hexdump -C tmp-rpb-glibc/work/all-linaro-linux/firmware-qcom-rb3gen2/00039.2/image/usr/lib/firmware/ath11k/WCN6750/hw1.0/board-2.bin
00000000  51 43 41 2d 41 54 48 31  31 4b 2d 42 4f 41 52 44  |QCA-ATH11K-BOARD|
00000010  00 6d 6d 6d                                       |.mmm|
00000014
lumag commented 2 weeks ago

@adhudase please post full dmesg of RB3gen2, including the WiFi startup messages.