search

Linaro / meta-qcom

OpenEmbedded/Yocto Project BSP layer for Qualcomm based platforms
MIT License
63 stars 76 forks source link

Fix build error if INITRAMFS_IMAGE undefined #637

Closed quic-vkraleti closed 2 months ago

quic-vkraleti commented 2 months ago

Fixed below error in linux-qcom-uki.bb when INITRAMFS_IMAGE is undefined.

ERROR: Error for linux-qcom-uki.bb:do_configure[depends], dependency '${@ '${INITRAMFS_IMAGE}:do_image_complete' if d.getVar('INITRAMFS_IMAGE') else ''}' does not contain exactly one ':' character. Task 'depends' should be specified in the form 'packagename:task'

lumag commented 2 months ago

Also could you please expand CI configuration so that such cases can be caught (please submit a PR with CI changes separately so that we can merge it first and then test this PR against the merged tree).

quic-vkraleti commented 2 months ago

and CI configuration so that such cases can be caught (please submit a PR with CI changes separately so that we can merge it first and then test this

Sure, I'll update CI scripts in a separate PR and get back.

lumag commented 2 months ago

I don't see CI failing after the CI change in #639 . Was it enough to demonstrate the issue being fixed by this PR?

quic-vkraleti commented 2 months ago

I don't see CI failing after the CI change in #639 . Was it enough to demonstrate the issue being fixed by this PR?

To reproduce need to set INITRAMFS_IMAGE = "". Is there any configuration in CI that tests kernel without initrd?

lumag commented 2 months ago

I don't see CI failing after the CI change in #639 . Was it enough to demonstrate the issue being fixed by this PR?

To reproduce need to set INITRAMFS_IMAGE = "". Is there any configuration in CI that tests kernel without initrd?

I asked you to add necessary CI configuration.

quic-vkraleti commented 2 months ago

I don't see CI failing after the CI change in #639 . Was it enough to demonstrate the issue being fixed by this PR?

To reproduce need to set INITRAMFS_IMAGE = "". Is there any configuration in CI that tests kernel without initrd?

I asked you to add necessary CI configuration.

https://github.com/Linaro/meta-qcom/pull/644 updated build template to build with & without initramfs.

lumag commented 2 months ago

@quic-vkraleti any chance of getting this done? I'd like to merge the fix and then backport necessary changes to the scarthgap branch.

quic-vkraleti commented 2 months ago

@quic-vkraleti any chance of getting this done? I'd like to merge the fix and then backport necessary changes to the scarthgap branch.

Sorry for the delay. Updated as requested. Please check.

lumag commented 2 months ago

Thank you! LGTM!