search

Linaro / squad

Software Quality Dashboard
GNU General Public License v3.0
59 stars 41 forks source link

for the suite resource, the name is always null, and the slug is always the name #885

Open jscook2345 opened 4 years ago

jscook2345 commented 4 years ago

Is there a historical reason for this? Could we deprecate one? It provides an inconsistent look-up when comparing to other resources. Especially when using as a filter in squad-client.

https://qa-reports.linaro.org/api/suites/5078/

HTTP 200 OK
Allow: GET, PUT, PATCH, DELETE, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "url": "https://qa-reports.linaro.org/api/suites/5078/",
    "id": 5078,
    "slug": "ltp-open-posix-tests",
    "name": null,
    "project": "https://qa-reports.linaro.org/api/projects/133/"
}
chaws commented 4 years ago

@jscook2345 I don't really know :/

@terceiro do you happen to know why we have suite name?

terceiro commented 4 years ago

IIRC name is supposed to be a human-readable name. it can be filled from the admin, but maybe it's pointless and we should just keep the slug

mwasilew commented 4 years ago

I don't think name was ever used. Maybe we should drop the field? Or make it alias to slug?