search

Linbreux / wikmd

A file based wiki that uses markdown
https://linbreux.github.io/wikmd/
MIT License
326 stars 37 forks source link

fix: use uri for search #152

Closed Jerakin closed 5 months ago

Jerakin commented 6 months ago

Summary

It's conventional to use a uri for searching

Details

It also makes the code cleaner as it do not have to guard against a search everywhere. Technically a breaking change as someone could have saved a search as a bookmark, or done other things that assumes the search location. However, I don't think that's worth taking into consideration.

Linbreux commented 5 months ago

Hi @Jerakin

I finally found some time to check your PRs. This change is indeed much cleaner. Thanks!