Lincoln-Murray / graphics_library

A small 3d graphics library/module for python
Creative Commons Attribution 4.0 International
4 stars 1 forks source link

Optimisatioins #5

Closed CaptainDeathead closed 1 month ago

CaptainDeathead commented 1 month ago

Done some optimizing, no major changes, however i did change the map_array to use rgb colours instead of hex, however it changes nothing on the frontend as its still converted from hex to rgb, but not every frame, at the start.

Lincoln-Murray commented 1 month ago

Throws an Error. PS C:\Users\maste\Documents\GitHub\graphics_library-captaindeathead\graphics_library> & C:/Users/maste/AppData/Local/Microsoft/WindowsApps/python3.11.exe c:/Users/maste/Documents/GitHub/graphics_library-captaindeathead/graphics_library/cube_demo.py Exception in Tkinter callback Traceback (most recent call last): File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64qbz5n2kfra8p0\Lib\tkinter\init.py", line 1967, in call return self.func(*args) ^^^^^^^^^^^^^^^^ File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64qbz5n2kfra8p0\Lib\tkinter__init__.py", line 861, in callit func(args) File "c:\Users\maste\Documents\GitHub\graphics_library-captaindeathead\graphics_library\cube_demo.py", line 36, in loop triangles = renderer.new_frame() ^^^^^^^^^^^^^^^^^^^^ File "c:\Users\maste\Documents\GitHub\graphics_library-captaindeathead\graphics_library\Main.py", line 248, in new_frame temp_tri = render_wall_from_normalised_points(sp[0][wall_num][0],sp[0][wall_num][1],sp[0][wall_num][2],sp[1][wall_num][0],sp[1][wall_num][1],sp[1][wall_num][2],sp[2][wall_num][0],sp[2][wall_num][1],sp[2][wall_num][2],wall[len(wall)-1], self.wiremesh, self.light_array, self.outline) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "c:\Users\maste\Documents\GitHub\graphics_library-captaindeathead\graphics_library\Main.py", line 120, in render_wall_from_normalised_points colour_x = dim_colour(colour,-nx(x/length), light) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "c:\Users\maste\Documents\GitHub\graphics_library-captaindeathead\graphics_library\Main.py", line 30, in dim_colour r, g, b = colour ^^^^^^^ ValueError: too many values to unpack (expected 3)