Closed GFJHogue closed 4 years ago
BlobFilehandleWrapper module code was copied from JBrowse in #98 along with others to modify file retrieval code to support GDC authentication token.
As I pointed out in the PR, BlobFilehandleWrapper seemed unnecessary to copy since it appeared to be unchanged from the original.
It turns out the return statement here was changed (probably for some local testing?) and breaks BAM retrieval in the @gmod/bam code: https://github.com/LincolnSteinLab/gdc-viewer/blob/develop/gdc-viewer/js/Model/BlobFilehandleWrapper.js#L14 https://github.com/GMOD/jbrowse/blob/master/src/JBrowse/Model/BlobFilehandleWrapper.js#L14 https://github.com/GMOD/bam-js/blob/master/src/bamFile.ts#L114
@gmod/bam
Best fix is to delete BlobFilehandleWrapper copy and use the JBrowse version.
BlobFilehandleWrapper module code was copied from JBrowse in #98 along with others to modify file retrieval code to support GDC authentication token.
As I pointed out in the PR, BlobFilehandleWrapper seemed unnecessary to copy since it appeared to be unchanged from the original.
It turns out the return statement here was changed (probably for some local testing?) and breaks BAM retrieval in the
@gmod/bamcode: https://github.com/LincolnSteinLab/gdc-viewer/blob/develop/gdc-viewer/js/Model/BlobFilehandleWrapper.js#L14 https://github.com/GMOD/jbrowse/blob/master/src/JBrowse/Model/BlobFilehandleWrapper.js#L14 https://github.com/GMOD/bam-js/blob/master/src/bamFile.ts#L114Best fix is to delete BlobFilehandleWrapper copy and use the JBrowse version.