search

Lind-Project / native_client

native_client trusted code base
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

More io speedup #126

Closed rennergade closed 1 year ago

rennergade commented 1 year ago

This PR removes some logging from the main I/O pathway that seems not necessary and causes slowdown.

It additionally gets rid of CopyTakeLock and DropLock functions that are only used for Windows.

Via nacl_copy.h note:


 * We use locking to prevent reads/writes of untrusted address space
 * while a hole is opened up in untrusted address space.
 *
 * Address space holes only occur on Windows, so we don't need this
 * locking in non-Windows builds, but we enable it in non-Windows
 * debug builds to help with earlier detection of deadlocks during
 * development.
 */```