Lind-Project / native_client

native_client trusted code base
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Signals #144

Closed rennergade closed 6 months ago

rennergade commented 10 months ago

Description

PR mostly via @jesings but with my help and some help from @AlpacaMax

Fixes # (issue) This PR adds signal handling through extensive changes to the signal runtime.

In depth explanation for these changes can be found in the extensive documentation at the top of nacl_signal.c and nacl_syscal_64.S

This PR also adds hooks for sigaction, sigprocmask, and kill.

Type of change

How Has This Been Tested?

WARNING: test suite will fail due to cross-repo PR Tests in lind_project Postgres/LAMP

Checklist:

yzhang71 commented 10 months ago

make[1]: *** [Makefile:20: lind/nacl] Error 1 make[1]: Leaving directory '/home/lind/lind_project/actions-runner/_work/native_client/native_client' make: *** [Makefile:17: nacl] Error 2 Error: Process completed with exit code 2. There are some errors in the make process.

rennergade commented 10 months ago

@yzhang71 I think your refactoring comments are valid but these things appear throughout the whole file and are kind of standard at this point, fixing all that would be a separate PR most likely