Originallytests/test_pipeline_run_airflow.py and tests/test_pipeline_run_script.py tested our pipeline generation "end to end" by grabbing the expected files and running them. This test is now changed to generate the pipeline files and test if they run in the same test.
Originally tests/test_writer.py simply tested to see if the generated files matched the snapshot of the file in expected directory. This made it very difficult to update the expected directory if changes are indeed expected to the snapshots. This has been updated now to use pytest snapshot.
Small changes:
left expected pickle files for pipeline test generation, since each generated pickle is not exactly the same as the previous they cannot be snapshotted.
removed dockerfile checks in test_writer due to not providing coverage but needing to be templated by python version.
Fixed github action for airflow tests
Type of change
Please delete options that are not relevant.
[X] Testing update
How Has This Been Tested?
Ensure new tests pass.
Ensure new snapshot tests actually snapshot all the generated files by inspecting contents of tests/unit/plugins/__snapshots__/test_writer.ambr manually.
Description
Changes to pipeline tests.
Originally
tests/test_pipeline_run_airflow.pyandtests/test_pipeline_run_script.pytested our pipeline generation "end to end" by grabbing the expected files and running them. This test is now changed to generate the pipeline files and test if they run in the same test.Originally
tests/test_writer.pysimply tested to see if the generated files matched the snapshot of the file inexpecteddirectory. This made it very difficult to update the expected directory if changes are indeed expected to the snapshots. This has been updated now to use pytest snapshot.Small changes:
test_writerdue to not providing coverage but needing to be templated by python version.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ensure new tests pass. Ensure new snapshot tests actually snapshot all the generated files by inspecting contents of
tests/unit/plugins/__snapshots__/test_writer.ambrmanually.