LinearTapeFileSystem / ltfs

Reference implementation of the LTFS format Spec for stand alone tape drive

BSD 3-Clause "New" or "Revised" License

256 stars 77 forks source link

Refactor the XML parser to return more graceful information #281

Closed piste-jp closed 3 years ago

piste-jp commented 3 years ago

Summary of changes

Generate graceful error information when an error happens while reading an index.

Fix of issue #110

Description

This PR includes the changes below.

Detect I/O error on xml read callbacks and report it at the end of parse
Detect incorrect value in the XML and report it correctly
The XML parser returns meaningful error code instead of -1

Fixes #110

Type of change

New feature (non-breaking change which adds functionality)
Refactoring

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have confirmed my fix is effective or that my feature works

piste-jp commented 3 years ago

Merged to v2.4-stable by cherry-pick