search

LinearTapeFileSystem / ltfs

Reference implementation of the LTFS format Spec for stand alone tape drive
BSD 3-Clause "New" or "Revised" License
256 stars 76 forks source link

ltfs_ordered_copy LTFS check error #370

Closed jycm205 closed 1 year ago

jycm205 commented 2 years ago

When I try running ltfs_ordered_copy to copy files to an LTFS formatted tape I get the following error:

Check destination:startswith first arg must be bytes or a tuple of bytes, not str

Copying to non-LTFS locations seems to work as expected.

If I print the value that xattr returns from an LTFS tape I get b'LTFS LE'. Should xattr be returning a string here? When running just the code related to generating and checking sig, I don't get an error if I convert sig to a string before checking if it starts with "LTFS" or if I change if sig.startswith("LTFS"): to if sig.startswith(b"LTFS"):.

I'm running the 2.4.5.0 release version on Fedora 36.

piste-jp commented 1 year ago

Thank you for your info. I confirmed.