LinearTapeFileSystem / ltfs

Reference implementation of the LTFS format Spec for stand alone tape drive

BSD 3-Clause "New" or "Revised" License

255 stars 76 forks source link

Fuse main log addition #404

Closed amissael95 closed 1 year ago

amissael95 commented 1 year ago

Summary of changes

This pull request includes following changes or fixes.

Fix of issue #403
Added warning message when fuse main function returns an error code.

Description

This change is needed to be able to track an error on fuse_main in case it happens.

Fixes #403

Type of change

New feature: Addition of warning message to show error code returned by fuse_main function.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have confirmed my fix is effective or that my feature works

amissael95 commented 1 year ago

@piste-jp-ibm I have seen that the Build for Debian9 is failing since some index files are not able to be downloaded during the validation process.

Do you know how can I solve this issue?

piste-jp commented 1 year ago

I have seen that the Build for Debian9 is failing since some index files are not able to be downloaded during the validation process.

It looks debian9 is little bit old. Need to consider to move to debian11 instead. But, as you know, I'm not an official owner of this project, I believe your team needs to handle such kind of operations for this project.

Of course, I can assist your team. But I don't have enough time to manage this project as I did before.

amissael95 commented 1 year ago

I have seen that the Build for Debian9 is failing since some index files are not able to be downloaded during the validation process.

It looks debian9 is little bit old. Need to consider to move to debian11 instead. But, as you know, I'm not an official owner of this project, I believe your team needs to handle such kind of operations for this project.

Of course, I can assist your team. But I don't have enough time to manage this project as I did before.

@piste-jp-ibm I also think that we should change it to Debian11 as you are commenting.

@juliocelon Could we work on this item together?

Regards

piste-jp commented 1 year ago

@piste-jp-ibm I also think that we should change it to Debian11 as you are commenting.

The build check except CentOS7/8 is optional. So it is not required for merging the change (when I'm managing this repository at least).

I recommend that you just remove Debian9 check build from the tree.

amissael95 commented 1 year ago

@piste-jp-ibm, all comments were addressed.

perezle commented 1 year ago

Message example:

This is how the warning will be shown on ltfs.log when LE is requested to be started:
[root@miller log]# grep 14123W ltfs.log | tail -n 1
2023-06-19T17:33:19.980700-06:00 miller ltfs[1819615]: 1bc3df LTFS14123W The main function of FUSE returned error (1).

I assume "1bc3df" will have a meaning under the FUSE return code spec. Right?

amissael95 commented 1 year ago

Message example: This is how the warning will be shown on ltfs.log when LE is requested to be started:
[root@miller log]# grep 14123W ltfs.log | tail -n 1
2023-06-19T17:33:19.980700-06:00 miller ltfs[1819615]: 1bc3df LTFS14123W The main function of FUSE returned error (1).
I assume "1bc3df" will have a meaning under the FUSE return code spec. Right?

It is just the thread id from where the message was show.

piste-jp commented 1 year ago

@juliocelon , @perezle

One of you need to merge this into the correct branch. At this time, v2.4-stable is the branch for IBM products. (Please use Squash and merge for keep the branch clean. Away from really tiny meaningless commits like Fix typos.)

piste-jp commented 1 year ago

@juliocelon , @perezle

It looks this PR is opened against the master branch. You have 2 options.

Merge this to the master with Squash and merge and then cherry-pick this to the v2.4-stable branch
Reject this and ask open another new PR against the v2.4-stable branch. After that merge the new one to the v2.4-stable branch and then cherry-pick to the master branch

juliocelon commented 1 year ago

@juliocelon , @perezle

It looks this PR is opened against the master branch. You have 2 options.

Merge this to the master with Squash and merge and then cherry-pick this to the v2.4-stable branch

Reject this and ask open another new PR against the v2.4-stable branch. After that merge the new one to the v2.4-stable branch and then cherry-pick to the master branch

Thanks, Abe-San, we will take option 1.

Merge this to the master with Squash and merge and then cherry-pick this to the v2.4-stable branch