search

Linekio / getmyancestors

Get GEDCOM files from FamilySearch.org
Other
163 stars 40 forks source link

Missing ordinance #19

Closed sebdu66 closed 5 years ago

sebdu66 commented 5 years ago

The initiatory ordinance is missing.

I add this at the line 636 : elif o["type"] == "http://lds.org/Initiatory": self.initiatory = Ordinance(o)

So for my needs it's working, but I think there need to have more change to integrate it in the gedcom

Linekio commented 5 years ago

There is no GEDCOM tag for initiatory : https://www.tamurajones.net/GEDCOMTags.xhtml

sebdu66 commented 5 years ago

I believe that the tag is WAC | Washing And Clothing.

From this source https://www.gedcompublisher.com/en/tag-types.htm WAC Other LDS Initiation

I will need to test with the PAF software to export to gedcom to see if it's really this one.

sebdu66 commented 5 years ago

I try PAF 4 and PAF 5 and they didn't have the option to add an initiatory. I try with rootsmagic and we can add it. I just created a test person and add only an iniatory to him then I export it to gedcom. I don't know how to read a gedcom ;) I see a WAC tag and the date that I put, 2 FEB 2019

Here is the result of the gedcom:

0 HEAD 1 SOUR RootsMagic 2 NAME RootsMagic 2 VERS 7.5.9.0 2 CORP RootsMagic, Inc. 3 ADDR PO Box 495 4 CONT Springville, UT 84663 4 CONT USA 3 PHON 1-800-ROOTSMAGIC 3 WWW www.RootsMagic.com 1 DEST RootsMagic 1 DATE 16 JUL 2019 1 FILE testt.ged 1 GEDC 2 VERS 5.5.1 2 FORM LINEAGE-LINKED 1 CHAR UTF-8 0 @I1@ INDI 1 NAME test /test/ 2 GIVN test 2 SURN test 1 SEX M 1 _UID 595AAB7C434745F5840945D60124A0636E3A 1 CHAN 2 DATE 16 JUL 2019 1 WAC 2 DATE 2 FEB 2019 2 STAT Completed 2 TEMP SWISS 0 _EVDEF BIRT 1 TYPE P 1 TITL Birth 1 ABBR Birth

Linekio commented 5 years ago

I think that PAF does'nt support GEDCOM 5.5.1. Anyway, I don't think there is any reason to use this software again, except to read old files. Seems that WAC tag isn't valid in GEDCOM 5.5.1, but only in older versions. So this file is not a valid 5.5.1 file. However, with GEDCOM, the usage is sometimes different from the specifications. Does Rootsmagic support Gedcom file import? Could you test importing a getmyancestors file, after manually adding a WAC tag?

sebdu66 commented 5 years ago

I install PAF just to try it. Yes we can import a gedcom to rootsmagic. I will try to manually add the WAC tag to a getmyancestors file

I will let you know of the result.

sebdu66 commented 5 years ago

I add this : 1 WAC 2 DATE 2 FEB 2019 2 STAT Completed 2 TEMP SWISS

And it's working

sebdu66 commented 5 years ago

Ok I made the update to the python file, I export 4 generations and it works well

Is it normal that the date for lds ordinances show like this +2017-02-04 and the software doesn't reconize the date ?

EDIT : If you want, I can make a pull request. EDIT : The WAC tag is back in GEDCOM 5.6

Linekio commented 5 years ago
sebdu66 commented 5 years ago

Thanks a lot for this code and for your support.