Abstract classes, constants and related functions.

Linekio / getmyancestors

Get GEDCOM files from FamilySearch.org

Other

164 stars 40 forks source link

Abstract classes, constants and related functions. #42

Closed changeling closed 2 years ago

changeling commented 2 years ago

I've separated classes, constants and related functions into shared modules for convenience, and to present the primary modules/scripts in a more digestible form.

Linekio commented 2 years ago

Hi, Thanks for this PR.

I think it would be nice if classes.py was separated into several files, maybe:

session.py (Session)
tree.py (Note, Source, Fact, Memorie, Name, Ordinance, Indi, Fam, Tree)
gedcom.py (Gedcom)
gui.py (fstogedcom classes)

changeling commented 2 years ago

Glad to do it. Take a look at these changes.

There are still some things to consider and probably some to clean up, maybe imports that could be streamlined. For one, I've moved constants.py and translation.py into the classes directory, so strictly speaking, it's not just classes. Maybe that's ok. Thoughts?

How does this look?

changeling commented 2 years ago

Just checking in.