search

Ling-Jun / LSTM-Stock-price

1 stars 1 forks source link

Integrate api #26

Closed Ling-Jun closed 4 years ago

Ling-Jun commented 4 years ago

Integrate API calls into script stockPredictor.py. Now we can run both 'train' and 'predict' in the one script.

Russell-Pollari commented 4 years ago

This is tough to review, seems like a lot of duplication of code.

Russell-Pollari commented 4 years ago

For example, you have three different versions of dataGenerator, as well as multiple predict and train files. I cannot follow very well which files are actually being used, + this makes changes very hard to add becuase you have to update all of these files that do the same function