search

LingDong- / psvg

Programmable Scalable Vector Graphics -- drawings that draw themselves
https://psvg.netlify.app/
300 stars 15 forks source link

Exclude dist from source control #12

Closed antfu closed 3 years ago

antfu commented 3 years ago

It's not ideal to keep dist files into the source control as it creates too much verbose and maybe potentially misalignment with the source. But having dist files could benefit users to grab and run without run into the install and build process. Or maybe we can guide users to download from npm or CDN dist instead: https://unpkg.com/@lingdong/psvg

What do you think?

LingDong- commented 3 years ago

I agree. Do npm/CDN automatically build the dist files? If so, then perfect, we can just put the links to those files in the README.

0918nobita commented 3 years ago

I also agree. I knew prepublishOnly npm script for building the dist files is already set up.

antfu commented 3 years ago

Do npm/CDN automatically build the dist files?

Yes. And if you don't mind, can I have the npm right to publish @lingdong/psvg so I can help manging the npm releases? (knowing you're busy :P) Thanks.

LingDong- commented 3 years ago

@antfu Awesome thanks! I added you as a maintainer on npm

antfu commented 3 years ago

Thanks. I will be going to remove the dist from git and update the corresponding readme.

antfu commented 3 years ago

Done. And released as v0.0.2. You may want to have a look at the readme to see if they match with your expectations.

LingDong- commented 3 years ago

Perfect. Thanks!