Closed NightFurySL2001 closed 4 years ago
Also please add a space. 🤣 Maybe copy the full-width space over to half-width space.
Hi, thanks for pointing these out!
I'm using less-common variant forms to generate those more often used characters. 𥿉 (糸末, U+25FC9) is a variant form of 襪 and 袜 https://www.zdic.net/hans/𥿉. Since there are currently no glyphs for 襪 and 袜, I'm filling them in with 𥿉. All the mapping rules can be found in data/variant_map.txt
.
Similarly 襍 is a variant form of 雜. https://www.zdic.net/hans/襍. However I didn't deliberately add it (雜 has its own glyph), it's more likely due to an error in the process. Will remove it.
祗 and 褸 are probably caused by OCR errors, I'll fix that.
I'll add both the ideographic space (U+3000) and space (U+0020).
Thanks again for spotting these errors.
祗 can be match with 𥿄(糸氐,U+25FC4) or its variant 纸 (has its own character already)?
紙 has its own glyph while 祗 doesn't, so I'll need to make 祗 fallback. List of characters that have their own glyphs is listed in data/labels_all.txt
Though by dictionary 朿 ≠ 束, it appeared in my original source (李長吉歌詩) as 束: 腸攢非束竹。胘急是張弓. So I guess that's kinda okay? 😂. Factually It is caused by OCR error though. There is a real, more correct 束 in the other source I was using (淮南鴻烈), so I'll switch 束 to that one and keep 朿 for, well, 朿.
Thanks for finding these errors!
Well current 朿 is from SHSerif so you may want to copy the glyph over from 束. Also I'm Chinese too so no worries :3
Hi @NightFurySL2001 ,
Now fixed:
Downloads on the release page are updated 🚀.
Issue fixed. Thanks for quick response!