LingDong- / qiji-font

齊伋體 - typeface from Ming Dynasty woodblock printed books
https://qiji-font.netlify.com/
SIL Open Font License 1.1
1.32k stars 71 forks source link

疑似错字 #12

Closed NightFurySL2001 closed 4 years ago

NightFurySL2001 commented 4 years ago

image

NightFurySL2001 commented 4 years ago

Also please add a space. 🤣 Maybe copy the full-width space over to half-width space. image

LingDong- commented 4 years ago

Hi, thanks for pointing these out!

Thanks again for spotting these errors.

NightFurySL2001 commented 4 years ago

祗 can be match with 𥿄(糸氐,U+25FC4) or its variant 纸 (has its own character already)?

NightFurySL2001 commented 4 years ago

image

LingDong- commented 4 years ago

紙 has its own glyph while 祗 doesn't, so I'll need to make 祗 fallback. List of characters that have their own glyphs is listed in data/labels_all.txt

Though by dictionary 朿 ≠ 束, it appeared in my original source (李長吉歌詩) as 束: 腸攢非束竹。胘急是張弓. So I guess that's kinda okay? 😂. Factually It is caused by OCR error though. There is a real, more correct 束 in the other source I was using (淮南鴻烈), so I'll switch 束 to that one and keep 朿 for, well, 朿.

Snip20200221_2

Thanks for finding these errors!

NightFurySL2001 commented 4 years ago

Well current 朿 is from SHSerif so you may want to copy the glyph over from 束. Also I'm Chinese too so no worries :3

LingDong- commented 4 years ago

Hi @NightFurySL2001 ,

Now fixed:

Downloads on the release page are updated 🚀.

NightFurySL2001 commented 4 years ago

Issue fixed. Thanks for quick response! image