Replace int with bool in token, type and string comparisons.

LingDong- / wax

A tiny programming language that transpiles to C, C++, Java, TypeScript, Python, C#, Swift, Lua and WebAssembly 🚀

https://waxc.netlify.app/

MIT License

783 stars 45 forks source link

Replace int with bool in token, type and string comparisons. #2

Closed efferifick closed 3 years ago

efferifick commented 3 years ago

Hello again,

I have this small patch with some refactoring. Please let me know if you don't like these types of small contributions and I can delete this branch. I have a couple of other small patches that I am interested in contributing if you would like.

LingDong- commented 3 years ago

Hi!

Thanks for the patch, however for this one I think I prefer int/0/1 over bool/true/false + additional header. Moreover 0s and 1s are used throughout other parts of the code that way, so I think it might be better to keep the current situation.

Nevertheless contributions are very welcome! (If it's a cosmetic change it'd be great if you can let me know what you're trying to fix in advance so I can decide :)

Thanks again!