Closed mingodad closed 3 years ago
TODO: need to free wat_strs
in function to_wat.c::tree_to_wat
Hi @mingodad ,
Thanks so much for all the fixes!
Looks good! Just wondering about a couple things:
(x)?(y):(z)
to x?y:z
, wouldn't that become problematic if one of the three operands is an assignment? e.g. (x=0)?1:2
is different from x=0?1:2
. Or perhaps not omitting the parenthesis in (x=y)
also avoids the problem. I haven't tested the changes yet, will clone your fork in a bit and try them out :)
Thanks again for the fixes!
Nice project ! In this first look I fixed several compiler warnings.