soc-pe-bot
commented
1 week ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Add command (Attempt to add a person being denied)
Description
When attempting to add a contact, I get the error message "Person already exists in the address book", even though, there is no person named "Alvin"
Steps to reproduce
Add "John Doe" which is the example given when given by the application an invalid add command
Copy the command and change the name to Alvin (Error is shown even if you change all the fields)
[original: nus-cs2103-AY2425S1/pe-interim#1138] [original labels: severity.High type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Justification for low: In actual scenario, unlikely that you will have students that have the same phone number or same email, or same class and register number.
Justification for feature flaw: According to guidelines, the error message provided is correct, however, we do admit that there could be more specifics provided regarding the error.
Justification for not in scope: The work done to the implement the feature for duplicate checking was more important than fixing this minor bug. Moreover, the system fails gracefully. (i.e. the system does not crash) However, we do acknowledge that the error message could be improved in future iterations to provide specifics as to why the provided student input is a duplicate.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [x] I disagree
Reason for disagreement: This definitely isn’t a duplicate issue as the original issue was having a unclear feedback message. This issue is your documentation having conflicts with your actual behavior by stating contradictory expected results.
## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** Also, i don’t think documentation saying expected result of “A” and your app giving the result of “B” is trivial and “NotInScope”. Same argument for issue type, your documentation doesn’t reflect your app’s behavior, so I believe should be documentation issue.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** Also, i don’t think documentation saying expected result of “A” and your app giving the result of “B” is trivial and “NotInScope”. Same argument for issue type, your documentation doesn’t reflect your app’s behavior, so I believe should be documentation issue.
Usecase 02 quotes " 3b. User enters a duplicate email. 3b1. System displays an error message notifying that the email already exists in the system. Use case ends." I tried it with the same email as alexyeoh, but i recieve a feedback message saying "person already exist" and not email already exist