Implemented parsing to Angular Formly.

LinioIT / dynamic-form-bundle

Generates symfony forms based on Yaml configuration files

18 stars 11 forks source link

Implemented parsing to Angular Formly. #4

Closed IsraelLinioMx closed 9 years ago

IsraelLinioMx commented 9 years ago

Implemented a FormlyFactory with tagged services.
Created specific strategies to every formly field.

nesl247 commented 9 years ago

Can you please update the title and body of the description? The title should be a short summary of what the pull request's purpose is, and the description should really explain it. If we look at what you have no, we have no idea what this PR is supposed to solve.

Thanks!

IsraelLinioMx commented 9 years ago

@nesl247 : I attended all your comments, let me know your thoughts.

nesl247 commented 9 years ago

@IsraelSanabriaMx One thing I also noticed is that you refactored the unit tests to use setup() with a bunch of properties in the test. There's really no reason to do this. It's much easier, and makes the tests more independent when you don't do this.

klaussilveira commented 9 years ago

:+1: