Create --table-max-width Flag for Custom Table Size

Link- / gh-stars

Search your starred ★ repositories on GitHub from your terminal

https://glich.stream

MIT License

16 stars 3 forks source link

Create --table-max-width Flag for Custom Table Size #11

Closed knbr13 closed 8 months ago

knbr13 commented 8 months ago

This PR addresses issue nb#2

The changes are just as follows:

create new variable to store the maximum width of the table.
pass this variable to the tableprinter.New function, to create a table with custom width.
add new flag to the root command, flag name: "table-max-width", flag shorthand name: "w".

knbr13 commented 8 months ago

Hello @Link- Thanks for your response.

What do you mean by "Add tests to cover this functionality"? What I did is just adding a new flag to make the table max width customizable by the user. I used functionalities that is already tested. I didn't come up with new logic.

Link- commented 8 months ago

@knbr13 - in https://github.com/Link-/gh-stars/blob/6020a3c4f3eea2b619fccc9d883994254c9450f7/cmd/root_test.go#L310 add a new scenario that will take a new table width input and test the output of the render function against a hard coded output.

Anyway, not a big deal.