search

Linkd-Inc / ngx-slideshow

An Agular 2+ slideshow component
5 stars 0 forks source link

unnecessary logs #11

Closed matanRP closed 6 years ago

matanRP commented 6 years ago

Bug Report or Feature Request (mark with an x)

- [X ] bug report -> please search issues before submitting
- [ ] feature request

Browser and Version?

Chrome, Firefox, Opera, Edge, etc. Please include the version number

Framework Versions

Output from: ng --version, in case you are using Angular CLI. Otherwise, output from: node --version , npm --version and Angular version.

Repro steps

Click on any of the sliders left or right

The log given by the failure

Desired functionality

There are two console.log() that left probably by mistake in the code. is it possible to remove them?

Mention any other details that might be useful

matanRP commented 6 years ago

Sorry forgot to mention versions: npm version : 5.4.2 node version: v8.8.1 ngx-slideshow: 0.0.10

crutchcorn commented 6 years ago

I totally forgot about removing console logs. 😅 I don't have my machine with me currently, so it might be a day or two until I can fix that. Otherwise, if you'd like to make a pull request (the code is pretty small and readable), feel free to!

crutchcorn commented 6 years ago

Closed with v0.0.11 released to npm just now