Allow percentage to be based off of ngx-slideshow size when viewport size is set manually
Mention any other details that might be useful
It will require a new input (with a default to allow previous uses of this library to upgrade without breaking) called resizeViewport or something like that where the input (again, default true) will decide whether or not to resize the viewport based on the card size or whether to make the viewport what the card size is based off of.
if (resizeViewport && unit.includes('%')) {
// Resize viewport to given percentage, grab px value and set to card size
} else if (!resizeViewport && unit.includes('%')) {
trueUnit = unit
}
Bug Report or Feature Request (mark with an
x
)When the viewport is sized programmatically, resizing the page doesn't work as expected.
EG: Infinite growing cards when using
flex-grow
OS and Version?
All
Repro steps
Desired functionality
Allow percentage to be based off of
ngx-slideshow
size when viewport size is set manuallyMention any other details that might be useful
It will require a new input (with a default to allow previous uses of this library to upgrade without breaking) called
resizeViewport
or something like that where the input (again, defaulttrue
) will decide whether or not to resize the viewport based on the card size or whether to make the viewport what the card size is based off of.