compiler properties in pom.xml

[agazzarini]

Hi @RubenVerborgh I changed a bit the pom.xml of the project because after importing it, Eclipse complained about a wrong usage of the @Override annotation. That is because in Java 5 (the default version picked up, at least by m2e) that annotation was allowed only between, strictly speaking, overriden methods; for instance it wasn't allowed between an interface method and its corresponding implementation (in another class) like org.linkeddatafragments.solver.BindingOne.vars()

Well, briefly: I change the pom.xml including Java 7 as target and source level. Also Java 6 could be good from that perspective but I think it's a bit old.

AG

[RubenVerborgh]

Thanks @agazzarini, however, this pull request does more than just that and also modifies the indentation and other things. Could you have a look at that? The diff should only show actual changes.

[agazzarini]

Other things? The indentation could be, maybe I pressed CRTL+ALT+F on Eclipse (I think my hands do that automatically ;)) but I'm sure there are no other substantials changes

However, I'm on my mobile, when I'll arrive at home I'll do a check On 20 Nov 2015 17:28, "Ruben Verborgh" notifications@github.com wrote:

Thanks @agazzarini https://github.com/agazzarini, however, this pull request does more than just that and also modifies the indentation and other things. Could you have a look at that? The diff should only show actual changes.

— Reply to this email directly or view it on GitHub https://github.com/LinkedDataFragments/Client.Java/pull/10#issuecomment-158451020 .

[agazzarini]

Sorry @RubenVerborgh, it seems my fault: I created the pull request after changing only the pom.xml and then, on my forked repo, I committed other changes. I didn't aware that pull requests continue to reference changes made to the source repository.

So you're right, there are a lot of other stuff which are not related with the pull request. I'll re-do that tomorrow.