search

LinkedDataFragments / Client.Java

A Triple Pattern Fragments client for Java (Jena)
MIT License
8 stars 10 forks source link

Updated to Apache Jena 2.12.1 #2

Closed egonw closed 9 years ago

egonw commented 9 years ago

Seemingly no big issues:

The test suite runs without any errors after this patch.

RubenVerborgh commented 9 years ago

I apologize @egonw that we let this slip by. It seems that #6 has the same purpose as this one, but yours was much earlier.

However, there's a big difference between #6 and yours, especially with the overrides thing. For me it's simple: if the methods override something, then @Override should be there. Could you please verify?

egonw commented 9 years ago

If the method still does overwrite something, then, yes, it should be kept... but looking at #6, I see the @Override annotation being removed too... anyway, no strong preference, as long as it makes it compile :)

RubenVerborgh commented 9 years ago

Well :smile: we're still having a discussion on that particular @Override. Because if it does not actually override anything, the entire method is never called.

Let's move the discussion over to #6, and I'll merge as soon as that's resolved.