search

LinkedDataFragments / Client.Java

A Triple Pattern Fragments client for Java (Jena)
MIT License
8 stars 10 forks source link

updates for support of Jena 2.13.0 (apache-jena-libs 2.13.0) #6

Closed m1ci closed 9 years ago

RubenVerborgh commented 9 years ago

Thanks, will look closely and merge.

RubenVerborgh commented 9 years ago

Alright, so the one thing stopping me from merging this is the @Override on weight.

Are we overriding a weight method in the base class or not? If we are, then @Override must be there.

If we are not, then @Override must not be there, but then the entire weight method becomes pointless, because nothing will ever call it.

Could you help to clarify this @m1ci or @egonw?

RubenVerborgh commented 9 years ago

Given that weight is still there in 2.13, we must keep @Override. If no objections, I'll change and merge like that.

egonw commented 9 years ago

Confirmed... still there, so, yes, overwrite... note, I don't think the annotation is required for it to actually overwrite the method... so, removing the method annotation should still overwrite the method, AFAIK.

RubenVerborgh commented 9 years ago

It's indeed not required, but it prevents us from making mistakes.

egonw commented 9 years ago

Agreed! But I don't understand why it gave a compile error, if the method was still there... maybe this has changed in Java8? Are you compiling with Java8 too? Maybe this is related: http://stackoverflow.com/a/27369217/217943, and maybe Java8 is more strict?

RubenVerborgh commented 9 years ago

Can you try to see if you have errors again? Maybe your compilation environment wasn't fully initialized yet?

RubenVerborgh commented 9 years ago

Merged as afddd7613833a4fea1a50b3ce40180d573177950.

egonw commented 9 years ago

OK, done testing. The current master compiles fine for me.

mielvds commented 9 years ago

Yes, java 8 is more strict on this, override is required, or at least the default compiler setting says so.