operators isiri, isblank and isliteral

[cKlee]

Is there any reason why this is not implemented yet?

https://github.com/cKlee/Client.js/blob/master/lib/util/SparqlExpressionEvaluator.js#L164-L172

[RubenVerborgh]

Time :wink:

[RubenVerborgh]

Also, a major rewrite of the expression engine is going on behind the scenes, so no major investments are planned in the current expression engine (but are welcome).

[cKlee]

So when you're rewriting pull requests to the old code is counterproductive?

[RubenVerborgh]

I said “welcome” :wink: Feel free to make a PR; it would need (minimal) tests though.

[cKlee]

Sure tests! I'm not familiar with the JS testing tools. How do I run this https://github.com/LinkedDataFragments/Client.js/blob/master/test/util/SparqlExpressionEvaluator-test.js ? Is it easy like http://mochajs.org/#getting-started ?

[RubenVerborgh]

Great! If you run npm test, everything will be tested.

To only test this specific part, do mocha test/util/SparqlExpressionEvaluator-test.js (after having run npm install -g mocha).

[cKlee]

Thanks!

[mielvds]

Careful, there is already effort on this: https://github.com/LinkedDataFragments/Client.js/blob/feature-more-filter-funtions/lib/util/SparqlExpressionEvaluator.js

and tests

https://github.com/LinkedDataFragments/Client.js/blob/feature-more-filter-funtions/test/util/SparqlExpressionEvaluator-test.js

[cKlee]

Ah ok! No hurry. Question answered. I close this.

[RubenVerborgh]

Sorry @mielvds and @cKlee, I was aware of that branch, but not the functions that had been implemented in this. We can still merge that branch, while the rewriting effort goes on.