search

LinkedDataFragments / Server.Java

A Triple Pattern Fragments server for Java
MIT License
27 stars 20 forks source link

Implement SPARQL datasource #58

Closed awoods closed 4 years ago

awoods commented 4 years ago

Resolves: #57

mielvds commented 4 years ago

cool thanks!

mielvds commented 4 years ago

@awoods I went a bit too fast here. Is this basically a copy paste of the Jena TDB datasource? What is the overlap and can it be reduced?

awoods commented 4 years ago

@mielvds : I built the pull-request in two parts to make the differences clear between the new SPARQL datasource and the existing Jena TDB datasource.

The first commit is a renamed copy of Jena TDB: https://github.com/LinkedDataFragments/Server.Java/pull/58/commits/3b20b53d1be86fe015c0ca77fad4f1bc403fa483

The second commit contains the changes from the copied Jena TDB: https://github.com/LinkedDataFragments/Server.Java/pull/58/commits/0db5c1cfc4538481e4617e79c158148a2edf3e8c

I believe the changes are significant enough to warrant two separate implementations... as currently structured.