LinkedDataFragments / Server.js

A Triple Pattern Fragments server for Node.js
http://linkeddatafragments.org/
Other
178 stars 59 forks source link

HDT version needs to be updated #83

Closed joachimvh closed 6 years ago

joachimvh commented 6 years ago

2 bugs have been found that both can probably be fixed by updating HDT to the latest version. We should check for any breaking changes though between the current version and the latest.

Problem 1: Some triples appear to be missing when requesting all results in a pattern. In the example here this is specifically a pattern with only a bound predicate, this may or may not be related. When looking at the results here, at the bottom we can see that there are some triples having "List of humble bundles" as subject, but when we go to the next page there are no further results like this, even though there should be.

Problem 2: The last triple keeps being repeated when going to a page further than the last one, e.g.: http://fragments.dbpedia.org/2015-10/en?subject=&predicate=http%3A%2F%2Fdbpedia.org%2Fproperty%2Fdeveloper&object=&page=500

RubenVerborgh commented 6 years ago

breaking changes

v2.x switched from callbacks to Promises, so yeah :smile:

RubenVerborgh commented 6 years ago

@joachimvh Can you verify whether #84 fixes those two issues?

joachimvh commented 6 years ago

It works now :+1: