search

LinkedEarth / Pyleoclim_util

Python Package for the Analysis of Paleoclimate Data. Documentation at
https://pyleoclim-util.readthedocs.io
GNU General Public License v3.0
87 stars 33 forks source link

summary_plot infected by lomb-scargle periodogram #180

Closed CommonClimate closed 2 years ago

CommonClimate commented 2 years ago

Describe the bug The PSD part of summary_plot() uses lomb-scargle by default; This makes no sense, as the whole point of the plot is to compare the WWZ scalogram to the WWZ PSD.

To Reproduce ts.summary_plot(), where ts is any Series object

Expected behavior Correspondance between WWZ scalogram and WWZ PSD

Screenshots summary_plot

khider commented 2 years ago

Steps for PSD/Scalogram:

  1. Preprocess the timeseries (detrend/standardize).
  2. Calculate PSD using the default method as WWZ
khider commented 2 years ago

And don't forget to update the doc strings:)

CommonClimate commented 2 years ago

Fixing issue #189 first will be a great help here.

CommonClimate commented 2 years ago

@alexkjames with issue #189 resolved, I believe you have all the pieces to put a wwz spectrum in summary_plot

alexkjames commented 2 years ago

Fixed with pull request #192